-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vectorization/pooling] add Pooling Nhwc Max Vectorization pass and relevant case #374
base: main
Are you sure you want to change the base?
[Vectorization/pooling] add Pooling Nhwc Max Vectorization pass and relevant case #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving quick feedback.
Additionally, please add unit test for your vectorization pass.
@@ -0,0 +1,50 @@ | |||
// RUN: buddy-opt %s \ | |||
// RUN: -convert-linalg-to-loops -lower-affine -convert-scf-to-cf \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please align this part of the code.
examples/MLIRVector/makefile
Outdated
|
||
vector-pooling-nhwc-max-run: | ||
@${MLIR_OPT} ./vector-pooling-nhwc-max.mlir \ | ||
-convert-vector-to-scf \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please align this part of the code.
@@ -0,0 +1,93 @@ | |||
// RUN: buddy-opt %s \ | |||
// RUN: -convert-vector-to-scf -lower-affine -convert-scf-to-cf \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please align this part of the code.
69600d8
to
d932f72
Compare
add Pooling Nhwc Max Vectorization pass and relevant case